Class GrpcStorageReadRequestHandler
- java.lang.Object
-
- com.linkedin.venice.listener.grpc.handlers.VeniceServerGrpcHandler
-
- com.linkedin.venice.listener.grpc.handlers.GrpcStorageReadRequestHandler
-
public class GrpcStorageReadRequestHandler extends VeniceServerGrpcHandler
This class is an incomplete copypasta of the logic inStorageReadRequestHandler.channelRead(ChannelHandlerContext, Object)
. Besides the maintenance issue of the repeated code, and the incomplete functionality support, another potentially big issue is that the threading model seems to be significantly different. This class does all the work in-line, in a blocking fashion. All of these disparities are likely to cause significant issues in terms of trying to ramp the gRPC path. TODO: Refactor with better abstractions so that gRPC and legacy endpoints have better code reuse and behavior parity.
-
-
Field Summary
-
Fields inherited from class com.linkedin.venice.listener.grpc.handlers.VeniceServerGrpcHandler
next
-
-
Constructor Summary
Constructors Constructor Description GrpcStorageReadRequestHandler(StorageReadRequestHandler storage)
-
Method Summary
All Methods Instance Methods Concrete Methods Modifier and Type Method Description void
processRequest(GrpcRequestContext ctx)
-
Methods inherited from class com.linkedin.venice.listener.grpc.handlers.VeniceServerGrpcHandler
addNextHandler, getNext, invokeNextHandler, writeResponse
-
-
-
-
Constructor Detail
-
GrpcStorageReadRequestHandler
public GrpcStorageReadRequestHandler(StorageReadRequestHandler storage)
-
-
Method Detail
-
processRequest
public void processRequest(GrpcRequestContext ctx)
- Specified by:
processRequest
in classVeniceServerGrpcHandler
-
-