Class GrpcStorageReadRequestHandler
java.lang.Object
com.linkedin.venice.listener.grpc.handlers.VeniceServerGrpcHandler
com.linkedin.venice.listener.grpc.handlers.GrpcStorageReadRequestHandler
This class is an incomplete copypasta of the logic in
StorageReadRequestHandler.channelRead(ChannelHandlerContext, Object)
.
Besides the maintenance issue of the repeated code, and the incomplete functionality support, another potentially big
issue is that the threading model seems to be significantly different. This class does all the work in-line, in a
blocking fashion. All of these disparities are likely to cause significant issues in terms of trying to ramp the gRPC
path.
TODO: Refactor with better abstractions so that gRPC and legacy endpoints have better code reuse and behavior parity.-
Field Summary
Fields inherited from class com.linkedin.venice.listener.grpc.handlers.VeniceServerGrpcHandler
next
-
Constructor Summary
Constructors -
Method Summary
Methods inherited from class com.linkedin.venice.listener.grpc.handlers.VeniceServerGrpcHandler
addNextHandler, getNext, invokeNextHandler, writeResponse
-
Constructor Details
-
GrpcStorageReadRequestHandler
-
-
Method Details
-
processRequest
- Specified by:
processRequest
in classVeniceServerGrpcHandler
-